Skip to content

Upgrade to Go 1.23.0 and update dependencies #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 23, 2025
Merged

Upgrade to Go 1.23.0 and update dependencies #66

merged 7 commits into from
Jul 23, 2025

Conversation

besendorf
Copy link
Collaborator

fixes #62

@besendorf
Copy link
Collaborator Author

not sure why CI run fails. Works on my machine with go 1.23

@besendorf besendorf mentioned this pull request Jul 17, 2025
Merged
roaree
roaree approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@roaree roaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments

go.mod
github.com/chzyer/readline v1.5.1 // indirect
github.com/gookit/color v1.5.4 // indirect
github.com/klauspost/compress v1.18.0 // indirect
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this https://github.com/xo/terminfo dependency is net new from the auto minor-version upgrade of https://github.com/gookit/color , which is ultimately required by our first-level dependency https://github.com/i582/cfmt. I wonder if there isn't a better way to do colored terminal output these days with less dependencies?

These are the only places where we call into the cfmt library as far as I can tell:

androidqf/log/logger.go

Line 84 in facb7a0

cfmt.Printf("{{%s}}::red|bold\n", msg)

androidqf/main.go

Lines 22 to 36 in facb7a0

func init() {
cfmt.Print(`
{{ __ _ __ ____ }}::green
{{ ____ ____ ____/ /________ (_)___/ /___ / __/ }}::yellow
{{ / __ '/ __ \/ __ / ___/ __ \/ / __ / __ '/ /_ }}::red
{{ / /_/ / / / / /_/ / / / /_/ / / /_/ / /_/ / __/ }}::magenta
{{ \__,_/_/ /_/\__,_/_/ \____/_/\__,_/\__, /_/ }}::blue
{{ /_/ }}::cyan
`)
cfmt.Println("\tandroidqf - Android Quick Forensics")
cfmt.Println()
}
func systemPause() {
cfmt.Println("Press {{Enter}}::bold|green to finish ...")

@besendorf besendorf merged commit 7c9bc2e into main Jul 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaree roaree roaree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update dependencies
2 participants
@besendorf @roaree